Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7361 Build PQS with Phoenix 5.2.0 #156

Merged
merged 3 commits into from
Jul 17, 2024
Merged

PHOENIX-7361 Build PQS with Phoenix 5.2.0 #156

merged 3 commits into from
Jul 17, 2024

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Jul 15, 2024

No description provided.

@stoty stoty requested a review from richardantal July 15, 2024 14:22
@richardantal
Copy link
Contributor

Can you please remove every mention of -Pshade-javax-servlet
in https://github.com/stoty/phoenix-queryserver/blob/PHOENIX-7361/python-phoenixdb/README.rst

richardantal
richardantal approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty merged commit d60e643 into apache:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardantal richardantal richardantal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @richardantal